Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

config: introduce the dc-location config #2925

Merged
merged 7 commits into from
Sep 9, 2020
Merged

Conversation

JmPotato
Copy link
Member

@JmPotato JmPotato commented Sep 8, 2020

Signed-off-by: JmPotato [email protected]

What problem does this PR solve?

Part of #2759. Introduce the dc-location and tso related configurations.

What is changed and how it works?

Add a new LocalTSOConfig to config pkg.

Check List

Tests

  • Unit test
  • Integration test

Code changes

  • Has configuration change

Release note

@JmPotato JmPotato added component/config Configuration logic. component/tso Timestamp Oracle. labels Sep 8, 2020
@ti-srebot ti-srebot added the status/LGT1 Indicates that a PR has LGTM 1. label Sep 8, 2020
server/config/config.go Outdated Show resolved Hide resolved
Copy link
Contributor

@Yisaer Yisaer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rest LGTM

server/config/config.go Outdated Show resolved Hide resolved
server/config/config.go Outdated Show resolved Hide resolved
Signed-off-by: JmPotato <[email protected]>
@JmPotato JmPotato requested a review from Yisaer September 8, 2020 12:40
Copy link
Contributor

@Yisaer Yisaer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-srebot ti-srebot removed the status/LGT1 Indicates that a PR has LGTM 1. label Sep 9, 2020
@ti-srebot ti-srebot added the status/LGT2 Indicates that a PR has LGTM 2. label Sep 9, 2020
@JmPotato
Copy link
Member Author

JmPotato commented Sep 9, 2020

/run-all-tests

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/config Configuration logic. component/tso Timestamp Oracle. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants